security: fix 4 HIGH blockers + PyJWT CVE + simplify publish workflow#55
Merged
Conversation
Security blockers (from pre-v0.3.0 audit): - F1 Silent key regeneration: auth/crypto.py now distinguishes FileNotFoundError (create new) from corruption/decrypt failure (raise). Prevents silent DID rotation that invalidates all previously-issued UAITs/credentials/anchors. - F2 DNS rebinding TOCTOU: auth/ssrf.py adds fetch_json_pinned with DNS pin; agent_card_service and did_service rewired to use it. Single DNS resolution, pinned IP used for connection. - F3 Gzip bomb / response size: fetch_json_pinned caps via iter_bytes with max_bytes check. Agent cards 1MB, DID Documents 256KB. - F4 Rate limiter reads wrong IP: api/main.py now parses X-Forwarded-For with trusted proxy list, LRU cap on in-memory dict to prevent memory DoS. Dependency fixes: - PyJWT[crypto]>=2.12.0 closes CVE-2026-32597 (crit header bypass) - cryptography>=46.0.7 closes CVE-2026-34073 (name constraints bypass) - python-multipart>=0.0.26 closes CVE-2026-40347 (DoS via mcp transitive) - Upper bounds added to all 10 runtime deps (prevent major drift) Publish workflow: - Simplified to single job, drop environment gate and id-token (blocked on Trusted Publishing setup), keep PYPI_API_TOKEN path. Tests: 358 passed, 1 skipped (POSIX chmod on Windows).
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 51 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (10)
Note
|
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
Previous attempts (commits 4605a7a, b96bf1d) to fix the publish workflow were overwritten by PR #55 which accidentally reintroduced the broken configuration. Trusted Publishing via OIDC is not configured on PyPI for this project, and the pypi environment gate combined with id-token write permission was producing startup_failure on every run attempt. Restore explicit password auth using the PYPI_API_TOKEN repository secret which is already configured. Drop the environment gate, the id-token write permission, and enable verbose output for easier debugging of any future token or upload issues.
5 tasks
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
…ng (#56) Previous attempts (commits 4605a7a, b96bf1d) to fix the publish workflow were overwritten by PR #55 which accidentally reintroduced the broken configuration. Trusted Publishing via OIDC is not configured on PyPI for this project, and the pypi environment gate combined with id-token write permission was producing startup_failure on every run attempt. Restore explicit password auth using the PYPI_API_TOKEN repository secret which is already configured. Drop the environment gate, the id-token write permission, and enable verbose output for easier debugging of any future token or upload issues.
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
…real integrations) Sync public docs and pyproject classifiers to the v0.3.0 ground truth after all today's merges (PRs #41, #42, #45, #46, #47, #48, #49, #50, #51, #55). README.md: - Update hero subtitle to 358 tests, 44 REST endpoints, and the 3 real framework integrations (LangChain, OpenAI Agents SDK, CrewAI). - Replace the 284 / 91 legacy test counts with the current split (358 passing, 1 skipped on Windows for POSIX chmod; 79 benchmarks). docs/changelog.md: - Add a full v0.3.0 section covering: real LangChain, OpenAI Agents, and CrewAI integrations; 7 framework examples + 15 integration tests; GitHub Actions CI/CD matrix across Python 3.10-3.13; EAS schema UID correctness; Annex III Article 43 differentiation; the CRITICAL delegation chain auth bypass fix; the security batch (SSRF, API timing, exception leaks, display_name, key perms); the 4 HIGH blockers fix + PyJWT CVE-2026-32597 mitigation + dependency pinning; and the test count move from 284 to 358. docs/roadmap.md: - Add Phase 3.5 (Complete, v0.3.0) describing the real framework integrations, CI/CD, and security hardening delivered today. - Note EAS integration is complete and testnet-ready on Base Sepolia but mainnet schema registration is still outstanding. - Rewrite the version plan: 0.3.0 is Phase 3.5 (shipped), 0.4.0 now targets broader GDPR coverage, ISO/IEC 42001 alignment, and EAS mainnet schema registration. ERC-8004 / A2A sync / ANS / Polygon ID move to 0.5.0. pyproject.toml: - Drop the Python 3.10 classifier so classifiers match the CI test matrix (3.11, 3.12, 3.13). requires-python remains >=3.10 for now so existing installs do not break. Out of tree (gitignored) and updated separately: - paper/internal/standards-coverage.md: reconciled test totals to 358, flagged DPDPA as NOT IMPLEMENTED (pitch reference only, no code), scoped broader GDPR beyond Article 17 to v0.4.0, and noted EAS mainnet schema is not yet registered. - MEMORY.md (global): updated version to 0.3.0, test count to 358, services to 12, REST endpoints to 44, GitHub stars to 15, PyPI totals 2,947 / 941 month, and documented the 10 merged PRs and the real-vs-simulated integration split.
4 tasks
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
…real integrations) (#58) Sync public docs and pyproject classifiers to the v0.3.0 ground truth after all today's merges (PRs #41, #42, #45, #46, #47, #48, #49, #50, #51, #55). README.md: - Update hero subtitle to 358 tests, 44 REST endpoints, and the 3 real framework integrations (LangChain, OpenAI Agents SDK, CrewAI). - Replace the 284 / 91 legacy test counts with the current split (358 passing, 1 skipped on Windows for POSIX chmod; 79 benchmarks). docs/changelog.md: - Add a full v0.3.0 section covering: real LangChain, OpenAI Agents, and CrewAI integrations; 7 framework examples + 15 integration tests; GitHub Actions CI/CD matrix across Python 3.10-3.13; EAS schema UID correctness; Annex III Article 43 differentiation; the CRITICAL delegation chain auth bypass fix; the security batch (SSRF, API timing, exception leaks, display_name, key perms); the 4 HIGH blockers fix + PyJWT CVE-2026-32597 mitigation + dependency pinning; and the test count move from 284 to 358. docs/roadmap.md: - Add Phase 3.5 (Complete, v0.3.0) describing the real framework integrations, CI/CD, and security hardening delivered today. - Note EAS integration is complete and testnet-ready on Base Sepolia but mainnet schema registration is still outstanding. - Rewrite the version plan: 0.3.0 is Phase 3.5 (shipped), 0.4.0 now targets broader GDPR coverage, ISO/IEC 42001 alignment, and EAS mainnet schema registration. ERC-8004 / A2A sync / ANS / Polygon ID move to 0.5.0. pyproject.toml: - Drop the Python 3.10 classifier so classifiers match the CI test matrix (3.11, 3.12, 3.13). requires-python remains >=3.10 for now so existing installs do not break. Out of tree (gitignored) and updated separately: - paper/internal/standards-coverage.md: reconciled test totals to 358, flagged DPDPA as NOT IMPLEMENTED (pitch reference only, no code), scoped broader GDPR beyond Article 17 to v0.4.0, and noted EAS mainnet schema is not yet registered. - MEMORY.md (global): updated version to 0.3.0, test count to 358, services to 12, REST endpoints to 44, GitHub stars to 15, PyPI totals 2,947 / 941 month, and documented the 10 merged PRs and the real-vs-simulated integration split.
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
…rce Cloudflare redeploy The Cloudflare Pages project is still wired to this monorepo's website/ subdirectory, not the split-out VibeTensor/attestix-website repo. When PR #1 and PR #2 merged in attestix-website, the live site never picked them up because Cloudflare was watching this directory instead. This commit replays both PRs against website/ so the live site actually updates before tomorrow's YC demo. Content fixes replayed from attestix-website#1 Replace 16-reps Julie Zhuo testimonial loop with three distinct real validation quotes (Yoshua Bengio, Alvaro Cabrejas Egea from the EU AI Office, Matt Pagett). Drop the second Marquee and lower repeat from 4 to 2 so the same quote does not surface 16 times in the DOM. Add VHS demo tape and asciinema walkthrough files under public/. Add a redirect stub at content/docs/guides/eu-compliance-walkthrough.mdx so the old link Matt Pagett hit no longer 404s. Content fixes replayed from attestix-website#2 Fix NumberTicker SSR so initial render shows the target value formatted with Intl.NumberFormat instead of the start value. Crawlers, no-JS visitors, and social previews now see 47 / 358 / 6 even if hydration never completes. On the client the component snaps to startValue on first-in-view and springs up to value, preserving the count-up effect. Add v0.3.0 flagship story to the landing page. Technology Stack gains a new Agent Frameworks category with LangChain, OpenAI Agents SDK, and CrewAI, labelled as real shipped integrations (not simulations). Hero subcopy and FAQ copy updated to mention the three integrations. Bump ATTESTIX_VERSION default and package.json version from 0.2.4 to 0.3.0. Replace stale 284 test counts with 358 (1 skipped on Windows) across the architecture guide, configuration reference, contributing guide, roadmap version plan, and research abstract. Historical 0.2.0 and 0.2.1 changelog entries keep their original 284 figure but now point forward to the 0.3.0 entry. Add a full 0.3.0 changelog entry covering every PR merged today: framework integrations (#41, #42, #48, #51), CI/CD setup (#49, #54, #56, #58), six security fixes (#45, #47, #55), EAS schema UID and Article 43 correctness fixes (#46, #50), and persona e2e polish (#57). Rewrite the sitemap generator to import the Fumadocs source loader and emit every docs page in content/docs/** automatically, weighted per section. The previous hand-maintained list surfaced only 4 of 17 docs pages to crawlers. The final sitemap now has 32 URLs (was 14).
ascender1729
added a commit
that referenced
this pull request
Apr 17, 2026
…rce Cloudflare redeploy (#60) The Cloudflare Pages project is still wired to this monorepo's website/ subdirectory, not the split-out VibeTensor/attestix-website repo. When PR #1 and PR #2 merged in attestix-website, the live site never picked them up because Cloudflare was watching this directory instead. This commit replays both PRs against website/ so the live site actually updates before tomorrow's YC demo. Content fixes replayed from attestix-website#1 Replace 16-reps Julie Zhuo testimonial loop with three distinct real validation quotes (Yoshua Bengio, Alvaro Cabrejas Egea from the EU AI Office, Matt Pagett). Drop the second Marquee and lower repeat from 4 to 2 so the same quote does not surface 16 times in the DOM. Add VHS demo tape and asciinema walkthrough files under public/. Add a redirect stub at content/docs/guides/eu-compliance-walkthrough.mdx so the old link Matt Pagett hit no longer 404s. Content fixes replayed from attestix-website#2 Fix NumberTicker SSR so initial render shows the target value formatted with Intl.NumberFormat instead of the start value. Crawlers, no-JS visitors, and social previews now see 47 / 358 / 6 even if hydration never completes. On the client the component snaps to startValue on first-in-view and springs up to value, preserving the count-up effect. Add v0.3.0 flagship story to the landing page. Technology Stack gains a new Agent Frameworks category with LangChain, OpenAI Agents SDK, and CrewAI, labelled as real shipped integrations (not simulations). Hero subcopy and FAQ copy updated to mention the three integrations. Bump ATTESTIX_VERSION default and package.json version from 0.2.4 to 0.3.0. Replace stale 284 test counts with 358 (1 skipped on Windows) across the architecture guide, configuration reference, contributing guide, roadmap version plan, and research abstract. Historical 0.2.0 and 0.2.1 changelog entries keep their original 284 figure but now point forward to the 0.3.0 entry. Add a full 0.3.0 changelog entry covering every PR merged today: framework integrations (#41, #42, #48, #51), CI/CD setup (#49, #54, #56, #58), six security fixes (#45, #47, #55), EAS schema UID and Article 43 correctness fixes (#46, #50), and persona e2e polish (#57). Rewrite the sitemap generator to import the Fumadocs source loader and emit every docs page in content/docs/** automatically, weighted per section. The previous hand-maintained list surfaced only 4 of 17 docs pages to crawlers. The final sitemap now has 32 URLs (was 14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the pre-v0.3.0 security audit work:
Security blockers fixed:
Dependency CVEs patched:
Tests: 358 passed, 1 skipped.