Skip to content

feat:iran map added#106

Open
premier213 wants to merge 1 commit into
VictorCazanave:masterfrom
premier213:master
Open

feat:iran map added#106
premier213 wants to merge 1 commit into
VictorCazanave:masterfrom
premier213:master

Conversation

@premier213

Copy link
Copy Markdown

iran map

@VictorCazanave VictorCazanave left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @premier213! 😃

Comment thread README.md
- 🇺🇸 [USA, Utah](packages/usa.utah)
- 🇺🇿 [Uzbekistan](packages/uzbekistan)
- 🌍 [World](packages/world)
- 🇿🇼 [Zimbabwe](packages/zimbabwe)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is due to autoformatting, but could you add the new map without modifying the rest of the file please?

Comment thread README.md
<tr>
<td align="center"><a href="https://github.com/keatonboyle"><img src="https://avatars3.githubusercontent.com/u/3393465?v=4?s=100" width="100px;" alt=""/><br /><sub><b>keatonboyle</b></sub></a><br /><a href="https://github.com/VictorCazanave/svg-maps/commits?author=keatonboyle" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/tyangjawi03"><img src="https://avatars0.githubusercontent.com/u/7666467?v=4?s=100" width="100px;" alt=""/><br /><sub><b>tyangjawi03</b></sub></a><br /><a href="https://github.com/VictorCazanave/svg-maps/commits?author=tyangjawi03" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/premier213"><img src="https://avatars.githubusercontent.com/u/4321174?v=4" width="100px;" alt=""/><br /><sub><b>premier213</b></sub></a><br /><a href="https://github.com/VictorCazanave/svg-maps/commits?author=premier213" title="Code">💻</a></td>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove that please? It will be added by a bot when your PR is merged.

Comment thread packages/iran/LICENSE.md
ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.

For more information, please refer to https://unlicense.org

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maps from mapsvg.com are under the Creative Commons Attribution 4.0 International license.

Comment thread packages/iran/README.md
@@ -0,0 +1,49 @@
# 🇮🇷 Iran

Contains all the states and the Federal District of Iran:

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to wikipedia, these are actually provinces.
If you know a better source of information, feel free to share it.

Comment thread packages/iran/README.md

This map is based on the work of [MapSVG](https://mapsvg.com).

The original map is available [here](https://mapsvg.com/maps/iran)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you complete the documentation please? You can look at the contributing guide or at another map (e.g. Canada)

Comment thread packages/iran/iran.svg
name="New York"
d="..."
/>
-->

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG is missing 😄

"publishConfig": {
"access": "public"
},
"license": "Unlicense"

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"license": "CC-BY-4.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants