Skip to content

Add Portugal map#121

Open
kalallit wants to merge 1 commit into
VictorCazanave:masterfrom
kalallit:master
Open

Add Portugal map#121
kalallit wants to merge 1 commit into
VictorCazanave:masterfrom
kalallit:master

Conversation

@kalallit

Copy link
Copy Markdown

No description provided.

@VictorCazanave VictorCazanave self-assigned this Dec 4, 2021
@VictorCazanave VictorCazanave self-requested a review December 4, 2021 04:41

@VictorCazanave VictorCazanave left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @kalallit ! 😃

It looks like you didn't finish (or forgot to push) the map creation. Please look at the contribution guide and/or the other maps.

@@ -0,0 +1,34 @@
# Portugal

@VictorCazanave VictorCazanave Dec 4, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you complete the documentation, add the license and the link in the main README please?

@@ -0,0 +1,20 @@
<svg viewBox="0 0 105 212" xmlns="http://www.w3.org/2000/svg" aria-label="Map of Portugal">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you format this file properly please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants