Skip to content

fix: Jaeger API returns 404 for recently ingested traces #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shreyas-quizizz wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

fix: Jaeger API returns 404 for recently ingested traces #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/vtselect/traces/query/query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ var (
"This limit affects Jaeger's /api/services/*/operations API.")

latencyOffset = flag.Duration("search.latencyOffset", 30*time.Second, "The time when a trace become visible in query results after the collection. see -insert.traceMaxDuration as well. (default 30s)")
recentTraceFallbackWindow = flag.Duration("search.recentTraceFallbackWindow", 5*time.Minute, "The time window for searching span data directly when the trace ID index has not been flushed yet. "+
"It affects Jaeger's /api/traces/<trace_id> API.")
)

var (
Expand Down Expand Up @@ -183,8 +185,10 @@ func GetTrace(ctx context.Context, cp *CommonParams, traceID string) ([]*Row, er
q.AddPipeOffsetLimit(0, 10)
traceStartTime, traceEndTime, err := findTraceIDTimeSplitTimeRange(ctx, q, cp)
if err != nil && errors.Is(err, vtstoragecommon.ErrOutOfRetention) {
// no hit in the retention period, simply returns empty.
return nil, nil
// The trace ID index may not have been flushed yet, but span data is already queryable.
// Fall back to searching span data directly over a recent time window.
recentStart := currentTime.Add(-*recentTraceFallbackWindow)
return findSpansByTraceIDAndTime(ctx, cp, traceID, recentStart, currentTime)
}
if err != nil {
// something wrong when trying to find the trace_id's start and end time.
Expand Down