bugfix: fix unsupported metric type for summary#127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Fix
unsupportedmetric type display in exposed metric metadata for summaries and quantiles by bumpingmetricsSDK version.This
unsupportedtype exists when a summary is not updated within a certain time window. See #120 and pull request VictoriaMetrics/metrics#121 for details.Checklist
The following checks are mandatory:
Summary by cubic
Fixes the wrong "unsupported" metric type in exposed metadata for summaries and quantiles by upgrading
github.com/VictoriaMetrics/metricsto v1.43.1. Also improves compatibility by exporting histograms as untyped.Bug Fixes
lelabel checks in collectors like OTEL.Dependencies
github.com/VictoriaMetrics/metricsfrom v1.41.2 to v1.43.1.Written for commit 0117a34. Summary will update on new commits.