add useLegacyNaming flag to switch between legacy (current chart naming) and operator naming

[AndrewChubatiuk]

added useLegacyNaming flag (default: true), which allows to define naming convention for plain k8s resources, that are managed by helm charts that do not contain operator. It allows for new users to have resources with naming convention, which is compatible with operator (useLegacyNaming: false)

[cubic-dev-ai]

1 issue found across 72 files

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[vrutkovs]

"vm.plain.fullname" seems to conflict with fullnameOverride with useLegacyNaming=false? We also have vm.fullname and vm.managed.fullname - do we need to update those too?

[AndrewChubatiuk]

"vm.plain.fullname" seems to conflict with fullnameOverride with useLegacyNaming=false? We also have vm.fullname and vm.managed.fullname - do we need to update those too?

good point! updated vm.plain.fullname and vm.managed.fullname, for vm.fullname it's not needed

[vrutkovs]

We still use vm.fullname in vlagent and vmanomaly charts - and these won't be affected by useLegacyNaming at all

[AndrewChubatiuk]

We still use vm.fullname in vlagent and vmanomaly charts - and these won't be affected by useLegacyNaming at all

now i'm thinking about keeping this useLegacyNaming for single and cluster instances only and migrate the rest to new convention

[vrutkovs]

Wouldn't that affect service names too, so users would have to reconfigure vmagent addresses? Perhaps we should take objects one by one and carefully check that upgrade passes as expected

[AndrewChubatiuk]

agree, probably also makes sense to add respective CR into each plain chart, it should cover one of existing issues