-
Notifications
You must be signed in to change notification settings - Fork 201
PR for a next 0.68.x release #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndrewChubatiuk
wants to merge
11
commits into
release-0.68
Choose a base branch
from
release-0.68-next
base: release-0.68
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8a325c1
use existing volume if it's name matches sts volume claim template (#…
AndrewChubatiuk db2027d
reconcile: properly handle parsing and get errors for prom objects (#…
AndrewChubatiuk 2d641bc
test: run upgrade test every time (#2048)
vrutkovs 55e1ae1
vmbackup: add eula flag for upgrade tests (#2049)
AndrewChubatiuk 330639d
test: add upgrade tests for 0.68.4 version (#2044)
vrutkovs 283f3a9
docs: update CHANGELOG
vrutkovs f5d6751
chore: migrate Openshift bundles to FBC (#2047)
vrutkovs 487149a
chore: use k8s apimachinery aggregate errors
vrutkovs aadb46d
Opm verification (#2089)
vrutkovs 534ef26
chore: convert more code to use k8s sets (#2088)
vrutkovs 66d4335
vmdistributed: change default write requests load balancing policy fr…
AndrewChubatiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ report.xml | |
| /bin/ | ||
| /build* | ||
| /bundle* | ||
| /catalog* | ||
| release | ||
| operator.zip | ||
| coverage.txt | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| package v1 | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "k8s.io/utils/ptr" | ||
|
|
||
| vmv1beta1 "github.com/VictoriaMetrics/operator/api/operator/v1beta1" | ||
| ) | ||
|
|
||
| func TestVTCluster_AvailableStorageNodeIDs(t *testing.T) { | ||
| f := func(cr *VTCluster, requestsType string, want []int32) { | ||
| t.Helper() | ||
| assert.Equal(t, want, cr.AvailableStorageNodeIDs(requestsType)) | ||
| } | ||
|
|
||
| cr := &VTCluster{ | ||
| Spec: VTClusterSpec{ | ||
| Storage: &VTStorage{ | ||
| CommonAppsParams: vmv1beta1.CommonAppsParams{ | ||
| ReplicaCount: ptr.To(int32(5)), | ||
| }, | ||
| MaintenanceSelectNodeIDs: []int32{1, 3}, | ||
| MaintenanceInsertNodeIDs: []int32{0, 4}, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| // select excludes maintenance nodes | ||
| f(cr, "select", []int32{0, 2, 4}) | ||
|
|
||
| // insert excludes maintenance nodes | ||
| f(cr, "insert", []int32{1, 2, 3}) | ||
|
|
||
| // no maintenance nodes | ||
| f(&VTCluster{ | ||
| Spec: VTClusterSpec{ | ||
| Storage: &VTStorage{ | ||
| CommonAppsParams: vmv1beta1.CommonAppsParams{ReplicaCount: ptr.To(int32(3))}, | ||
| }, | ||
| }, | ||
| }, "select", []int32{0, 1, 2}) | ||
| } | ||
|
|
||
| func TestVLCluster_AvailableStorageNodeIDs(t *testing.T) { | ||
| f := func(cr *VLCluster, requestsType string, want []int32) { | ||
| t.Helper() | ||
| assert.Equal(t, want, cr.AvailableStorageNodeIDs(requestsType)) | ||
| } | ||
|
|
||
| cr := &VLCluster{ | ||
| Spec: VLClusterSpec{ | ||
| VLStorage: &VLStorage{ | ||
| CommonAppsParams: vmv1beta1.CommonAppsParams{ | ||
| ReplicaCount: ptr.To(int32(5)), | ||
| }, | ||
| MaintenanceSelectNodeIDs: []int32{1, 3}, | ||
| MaintenanceInsertNodeIDs: []int32{0, 4}, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| // select excludes maintenance nodes | ||
| f(cr, "select", []int32{0, 2, 4}) | ||
|
|
||
| // insert excludes maintenance nodes | ||
| f(cr, "insert", []int32{1, 2, 3}) | ||
|
|
||
| // no maintenance nodes | ||
| f(&VLCluster{ | ||
| Spec: VLClusterSpec{ | ||
| VLStorage: &VLStorage{ | ||
| CommonAppsParams: vmv1beta1.CommonAppsParams{ReplicaCount: ptr.To(int32(3))}, | ||
| }, | ||
| }, | ||
| }, "select", []int32{0, 1, 2}) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Initialize
PREV_CATALOGto a valid default before conditional assignment; it is currently used unconditionally and can break the workflow when no prior catalog exists.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an issue - prior catalog exists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying—the prior catalog exists, so this isn’t an issue here.