Skip to content

vmauth: introduce arbitrary fs access#2095

Merged
AndrewChubatiuk merged 3 commits intomasterfrom
vmauth-arbitrary-fs-access
Apr 23, 2026
Merged

vmauth: introduce arbitrary fs access#2095
AndrewChubatiuk merged 3 commits intomasterfrom
vmauth-arbitrary-fs-access

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Apr 22, 2026

fixes #899


Summary by cubic

Adds arbitraryFSAccessThroughSMs to VMAuth to allow or block file-path references in VMUser configs. When denied, VMAuth rejects users that reference node files (e.g., bearer tokens, basic auth, TLS files).

  • New Features
    • Added arbitraryFSAccessThroughSMs.deny to VMAuthSpec; when true, VMUser.ValidateArbitraryFSAccess() blocks configs with file-path refs (e.g., TLS cert/key/CA).
    • Updated CRDs, deepcopy, and docs (API includes VMAuthSpec; CHANGELOG entry added).

Written for commit 363c0be. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:16">
P2: Custom agent: **Changelog Review Agent**

Changelog entry is missing the mandatory user-centric before/now/user-visible impact explanation.</violation>
</file>

<file name="internal/controller/operator/factory/vmauth/vmusers_config.go">

<violation number="1" location="internal/controller/operator/factory/vmauth/vmusers_config.go:126">
P1: `arbitraryFSAccessThroughSMs.deny` is enforced only for VMUser entries, so `unauthorizedUserAccessSpec` can still inject file-based TLS paths and bypass the deny policy.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread internal/controller/operator/factory/vmauth/vmusers_config.go
Comment thread docs/CHANGELOG.md Outdated
AndrewChubatiuk and others added 3 commits April 23, 2026 14:13
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Signed-off-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
@AndrewChubatiuk AndrewChubatiuk force-pushed the vmauth-arbitrary-fs-access branch from ab545c4 to 363c0be Compare April 23, 2026 11:14
@AndrewChubatiuk AndrewChubatiuk merged commit 5c05ab1 into master Apr 23, 2026
5 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the vmauth-arbitrary-fs-access branch April 23, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security improvements for filesystem access.

2 participants