Common labels

[vrutkovs]

This ensures HTTPRoutes and PVCs include ManagedMetadata labels and annotations.

Fixes #2094

TODO:

• Implement passing commonLabel/managedMetadata in pod templates too

[AndrewChubatiuk]

let's avoid adding any github.com/VictoriaMetrics/operator/internal/* package in api. probably it can be done in defaults.go instead

[cubic-dev-ai]

1 issue found across 34 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="internal/config/config.go">

<violation number="1" location="internal/config/config.go:630">
P2: Use the documented `envKeyValSeparator` tag; `envKeyValueSeparator` is ignored, so the new label/annotation env vars won't parse as `key=value` pairs.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.}

[AndrewChubatiuk]

Overall looks good! could you please also add test to cover an attempt to overwrite standard labels using commonLabels?

[AndrewChubatiuk]

not sure this is needed, we don't manage namespaces

[AndrewChubatiuk]

also don't understand why this function should be applied to all core k8s resources? isn't it enough to extend addDefaultMetadata to patch ManagedMetadata? also not sure if this should be applied to pods as well

[vrutkovs]

I'd rather add those preemptively, as some feature may start managing those resources later.

also don't understand why this function should be applied to all core k8s resources?

My understanding is that if the object (VMAgent) creates a deployment and the service, we should make sure both have propagated labels and annotations. I'm not sure that omitting pods / child resources is sufficient for OPA.

also not sure if this should be applied to pods as well

I think so, yeah