Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:17">
P3: Improve this changelog sentence for clarity and correctness: use “allows disabling read, write, or all traffic to a zone.”
(Based on your team's feedback about clarifying behavior and roles in documentation text.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
vrutkovs
reviewed
Apr 24, 2026
AndrewChubatiuk
force-pushed
the
vmdistributed-traffic-modes
branch
from
15a23ec to
827eaa1
Compare
vrutkovs
reviewed
Apr 24, 2026
Collaborator
vrutkovs
left a comment
vrutkovs
left a comment
There was a problem hiding this comment.
Looks good overall, but it needs a few more unit tests and e2e test preferably - and example / documentation update
| vmCluster.Spec = *vmClusterSpec | ||
| rclient.Scheme().Default(&vmCluster) | ||
| if (z.TrafficMode == vmv1alpha1.VMDistributedTrafficModeReadOnly || z.TrafficMode == vmv1alpha1.VMDistributedTrafficModeMaintenance) && vmCluster.Spec.VMInsert != nil { | ||
| vmCluster.Spec.VMInsert.ReplicaCount = ptr.To(int32(0)) |
Collaborator
There was a problem hiding this comment.
Wouldn't that make vmagent start accumulating the queue for RO clusters? Also, needs a comment why we do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1995
Summary by cubic
Add per‑zone traffic modes to
vmdistributedto control read and write routing. This lets you put a zone into read-only, write-only, read-write, or maintenance without removing it.spec.zones[*].trafficModewithread-write(default),read-only,write-only,maintenance.vmauthnow routes by mode:read-onlyexcluded from write targets;write-onlyfrom read targets;maintenancefrom both.read-onlyormaintenance, the zone’sVMInsertis scaled to 0 replicas to block writes.trafficModetoread-write; CRDs, API docs, and CHANGELOG updated.Written for commit 827eaa1. Summary will update on new commits.