serialize relation modifier and alias before the recursion marker#2810
Open
Noethix55555 wants to merge 1 commit into
Open
serialize relation modifier and alias before the recursion marker#2810Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
RelationExpression.toString appended the recursion suffix (.^, .^N, .*) before the modifier (f1) and alias (as b). The grammar requires name, args and alias before the recursion subexpression, so a node like a(f1).^ serialized to a.^(f1) (modifier dropped on reparse) and a as b.^ to a.^ as b (mis-parsed). Emit modifier and alias first so the output round-trips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RelationExpression.toStringappends the recursion suffix (.^,.^N,.*) to the relation name before it appends the$modifymodifier ((f1)) and the alias (as b). The expression grammar requiresname args? alias?before the recursion subexpression, so the output does not round-trip when recursion is combined with a modifier or alias:Fix emits the modifier and alias before the recursion marker. Added round-trip cases (
a(f1).^,a(f1).^3,a as b.^,a(f1) as b.^) to the toString tests; they fail on the current code and pass with the change.