Skip to content

Introduce config that is loaded from file#24

Merged
rochala merged 6 commits intoVirtusLab:mainfrom
yhefamly:introduce-config
Apr 7, 2026
Merged

Introduce config that is loaded from file#24
rochala merged 6 commits intoVirtusLab:mainfrom
yhefamly:introduce-config

Conversation

@yhefamly
Copy link
Copy Markdown
Contributor

@yhefamly yhefamly commented Apr 4, 2026

To allow users to conveniently configure certain aspects of cellar, introduce an optional config file. For starters, this allows configuring the mill and sbt binaries as well as the sbt invocation mode. Ships with a built-in default config that does not alter the current behavior.

Closes #22

To allow users to conveniently configure certain aspects of cellar, introduce an optional config file. For starters, this allows configuring the mill and sbt binaries as well as the sbt invocation mode. Ships with a built-in default config that does not alter the current behavior.
Comment thread lib/src/cellar/Config.scala Outdated
This allows users to override the config via env vars, not only via a local config file.
Comment thread lib/src/cellar/Config.scala Outdated
Comment thread lib/src/cellar/Config.scala Outdated
Comment thread cli/resources/reference.conf Outdated
Comment thread lib/src/cellar/Config.scala Outdated
@yhefamly yhefamly requested a review from rochala April 6, 2026 11:22
@rochala
Copy link
Copy Markdown
Contributor

rochala commented Apr 7, 2026

It looks like this PR broke a test cellar.ProjectAwareIntegrationTest

@yhefamly
Copy link
Copy Markdown
Contributor Author

yhefamly commented Apr 7, 2026

It looks like this PR broke a test cellar.ProjectAwareIntegrationTest

@rochala Fixed in 19d93e7.

@rochala rochala merged commit bf3adc3 into VirtusLab:main Apr 7, 2026
2 checks passed
@rochala
Copy link
Copy Markdown
Contributor

rochala commented Apr 7, 2026

Thank you so much for the contribution :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider supporting sbt --client

2 participants