Accessing interest groups from the same site#245
Conversation
| 'prevWins': [[time1,ad1],[time2,ad2],...], | ||
| } | ||
| ``` | ||
| * sameSiteInterestGroups: if the user is added to `interestGroup` on a single site, this argement contains a list of all other interest group objects added by that site; if the user is added to `interestGroup` on mutliple sites, this argument will be empty. |
There was a problem hiding this comment.
Empty as in the empty list?
|
I think there is a potential leak here. Imagine I operate sites A and B. On site A I add users to two IGs: IG_BOTH and IG_A. On site B I also add users to two IGs: IG_BOTH and IG_B. In (I don't know whether this leak is acceptable, but we should think about it.) |
| } | ||
| ``` | ||
| * sameSiteInterestGroups: if the user is added to `interestGroup` on a single site, this argement contains a list of all other interest group objects added by that site; if the user is added to `interestGroup` on mutliple sites, this argument will be empty. | ||
| * sameSiteInterestGroups: if the user is added to `interestGroup` on a single site, this argument contains a list of all other interest group objects added by that site; if the user is added to `interestGroup` on mutliple sites, this argument will be a empty list. |
There was a problem hiding this comment.
nit/typos:
- Capital I for the first "if"
- added by that site -> added on that site
- Instead of the whole phrase "if the user ....", maybe just say "otherwise"?
- mutliple -> multiple
- a empty list -> an empty list
Actually, this leak exists today with (A buyer could transfer even more information by having site |
|
|
This pull request has been open for a long time but I don't think it addresses my comment. Can I ask that it close it until we have a solution to the issue that I raised? |
JensenPaul
added
the
Non-breaking Feature Request
4 participants
Fixes #162