feat(spec/ext): add Extensions API specification#653
Merged
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Looks good to me. |
sidvishnoi
changed the title
sidvishnoi
reviewed
Mar 30, 2026
Comment on lines
+32
to
+35
| <dt><dfn>url</dfn></dt> | ||
| <dd> | ||
| The URL of the monetized document. | ||
| </dd> |
Collaborator
There was a problem hiding this comment.
- How is this intended to be used?
- Is this frame URL or tab URL?
- This inherently exposes some details that require
tabspermission. If this is meant to betab.url, should we defer that to existingtabspermission?
Member
Author
There was a problem hiding this comment.
That's a bigger question which we probably should move out of context of this starter doc, now it just my match the implementation we have. I started a new issue #655
sidvishnoi
reviewed
Mar 30, 2026
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.