Skip to content

chore(clean): remove tailwind classes from components#3268

Merged
cnairi merged 1 commit intomainfrom
chore-remain-tailwind-classes-from-components
Apr 9, 2026
Merged

chore(clean): remove tailwind classes from components#3268
cnairi merged 1 commit intomainfrom
chore-remain-tailwind-classes-from-components

Conversation

@cnairi
Copy link
Copy Markdown
Contributor

@cnairi cnairi commented Apr 8, 2026

DESCRIPTION

We need to remove the tailwind classes from our components code. It's not what we settled on and we want to remain independent from Tailwind on WUI side.

Only our application consuming welcome-ui can use Tailwind (that's why it's ok in the doc examples).

This is why we had this issue here: https://wttj.slack.com/archives/CJ4KGFA75/p1774855869741119
and needed to do a workaround @source '../../node_modules/welcome-ui'; that should NOT be necessary!

HOW TO TEST

This changes the code of the following components:

  • Alert
  • Drawer/AssetDrawer
  • Pagination
  • Select
  • Tabs
  • WelcomeLoader

SCREENSHOTS / SCREEN RECORDINGS

N/A ➡️ it should NOT change anything

COMPATIBILITY

  • Tested on Safari (desktop)
  • Tested on Chrome (desktop)
  • Tested on Firefox (desktop)
  • Tested on mobile device sizes
  • Tested on tablet device sizes
  • Tested on IOS Safari (either device or simulator)

QA

  • Thoroughly tested in local environment
  • Added tests for all new features
  • Added tests that considered edge cases

@github-actions github-actions bot added the wip label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

👀 Visit Preview

@cnairi cnairi force-pushed the chore-remain-tailwind-classes-from-components branch from 2956732 to 83e18d8 Compare April 8, 2026 14:47
@cnairi cnairi force-pushed the chore-remain-tailwind-classes-from-components branch from 83e18d8 to 6b38931 Compare April 8, 2026 14:49
@cnairi cnairi marked this pull request as ready for review April 8, 2026 14:50
@cnairi cnairi requested a review from a team as a code owner April 8, 2026 14:50
@github-actions github-actions bot added to-review and removed wip labels Apr 8, 2026
Copy link
Copy Markdown
Contributor

@Leiksa Leiksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the goat, thank you so much for this!! 🙏🏼

Copy link
Copy Markdown
Contributor

@RobelTekle RobelTekle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

@cnairi cnairi merged commit e26228a into main Apr 9, 2026
16 checks passed
@cnairi cnairi deleted the chore-remain-tailwind-classes-from-components branch April 9, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants