Skip to content

chore(Dropdown Trigger): remove event stopPropagation#3269

Merged
RobelTekle merged 1 commit intomainfrom
chore-dropdown-trigger-remove-event-stop-and-prevent-default
Apr 10, 2026
Merged

chore(Dropdown Trigger): remove event stopPropagation#3269
RobelTekle merged 1 commit intomainfrom
chore-dropdown-trigger-remove-event-stop-and-prevent-default

Conversation

@RobelTekle
Copy link
Copy Markdown
Contributor

@RobelTekle RobelTekle commented Apr 9, 2026

DESCRIPTION

This PR aims to:

  • Remove event stopPropagation from the DropdownMenu.Trigger onClick
  • Add a comment on why we have a e.preventDefault on the onClick

HOW TO TEST

SCREENSHOTS / SCREEN RECORDINGS

COMPATIBILITY

  • Tested on Safari (desktop)
  • Tested on Chrome (desktop)
  • Tested on Firefox (desktop)
  • Tested on mobile device sizes
  • Tested on tablet device sizes
  • Tested on IOS Safari (either device or simulator)

QA

  • Thoroughly tested in local environment
  • Added tests for all new features
  • Added tests that considered edge cases

@github-actions github-actions bot added the wip label Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

👀 Visit Preview

@RobelTekle RobelTekle force-pushed the chore-dropdown-trigger-remove-event-stop-and-prevent-default branch from 327f376 to 862d4c8 Compare April 9, 2026 16:02
@RobelTekle RobelTekle changed the title chore(Dropdown Trigger): remove event stopPropagation & preventDefault chore(Dropdown Trigger): remove event stopPropagation Apr 9, 2026
@RobelTekle RobelTekle marked this pull request as ready for review April 9, 2026 16:15
@RobelTekle RobelTekle requested a review from a team as a code owner April 9, 2026 16:15
@github-actions github-actions bot added to-review and removed wip labels Apr 9, 2026
@linear
Copy link
Copy Markdown

linear bot commented Apr 9, 2026

@RobelTekle RobelTekle merged commit a1ae90c into main Apr 10, 2026
11 checks passed
@RobelTekle RobelTekle deleted the chore-dropdown-trigger-remove-event-stop-and-prevent-default branch April 10, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants