fix: pino esm - #252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ESM (ECMAScript Modules) compatibility issues with the Pino logger import by replacing the problematic named default import with a more robust import pattern that handles both CommonJS and ESM environments.
- Replaces named default import with namespace import and fallback logic
- Removes ESLint disable comment that was needed for the previous import pattern
- Maintains the same export interface for backward compatibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bkrem
approved these changes
Oct 8, 2025
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Update logger to import and re-export pino compatibly with ESM/CJS and bump package to 2.1.3.
misc/logger):src/index.tstoimport * as Pinoand exportdefaultPino as pino(fallback toPino.default ?? Pino).package.jsonfrom2.1.2to2.1.3.Written by Cursor Bugbot for commit c98e920. This will update automatically on new commits. Configure here.