Skip to content

fix: pino esm - #252

Merged
ganchoradkov merged 4 commits into
masterfrom
fix/pino-esm
Oct 8, 2025
Merged

fix: pino esm#252
ganchoradkov merged 4 commits into
masterfrom
fix/pino-esm

Conversation

@ganchoradkov

@ganchoradkov ganchoradkov commented Oct 8, 2025

Copy link
Copy Markdown
Member

Note

Update logger to import and re-export pino compatibly with ESM/CJS and bump package to 2.1.3.

  • Logger (misc/logger):
    • ESM/CJS interop: Change src/index.ts to import * as Pino and export defaultPino as pino (fallback to Pino.default ?? Pino).
    • Version: Bump package.json from 2.1.2 to 2.1.3.

Written by Cursor Bugbot for commit c98e920. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings October 8, 2025 10:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes ESM (ECMAScript Modules) compatibility issues with the Pino logger import by replacing the problematic named default import with a more robust import pattern that handles both CommonJS and ESM environments.

  • Replaces named default import with namespace import and fallback logic
  • Removes ESLint disable comment that was needed for the previous import pattern
  • Maintains the same export interface for backward compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

cursor[bot]

This comment was marked as outdated.

@ganchoradkov
ganchoradkov requested a review from bkrem October 8, 2025 11:15
cursor[bot]

This comment was marked as outdated.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​walletconnect/​logger@​2.1.2 ⏵ 2.1.3100 +1100100 +34100 +20100

View full report

@ganchoradkov
ganchoradkov merged commit ff9fdcb into master Oct 8, 2025
50 of 51 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants