Skip to content

fix(safe-json): parse negative BigInts #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bramcohen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(safe-json): parse negative BigInts #274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
851534e
Fixed bug where negative integers aren't parsed properly
bramcohen Jul 15, 2026
caa9823
FIxed bug in parsing of negative numbers with magnitude greater than …
bramcohen Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion misc/safe-json/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const JSONParse = (json: string) => {
const numbersBiggerThanMaxInt = /(?<!")(?<=:)\b(\d{17,}|(?:[9](?:[1-9]07199254740991|0[1-9]7199254740991|00[8-9]199254740991|007[2-9]99254740991|007199[3-9]54740991|0071992[6-9]4740991|00719925[5-9]740991|007199254[8-9]40991|0071992547[5-9]0991|00719925474[1-9]991|00719925474099[2-9])))(?=[,\}\]]|$)/g;
Comment thread
bramcohen marked this conversation as resolved.
Outdated
const serializedData = json.replace(numbersBiggerThanMaxInt, (match) => `"${match}n"`);
return JSON.parse(serializedData, (_, value) => {
const isCustomFormatBigInt = typeof value === "string" && value.match(/^\d+n$/);
const isCustomFormatBigInt = typeof value === "string" && value.match(/^-?\d+n$/);

if (isCustomFormatBigInt) return BigInt(value.substring(0, value.length - 1));

Expand Down
4 changes: 4 additions & 0 deletions misc/safe-json/test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ describe("@walletconnect/safe-json", () => {
const result = safeJsonParse(safeJsonStringify({ bigint: BigInt(1) }));
chai.expect(result).to.deep.eq({ bigint: BigInt(1) });
});
it("should handle negative bigint", () => {
const result = safeJsonParse(safeJsonStringify({ amount: BigInt(-100) }));
chai.expect(result).to.deep.eq({ amount: BigInt(-100) });
});
it("should handle number inside string literal. Case 1", () => {
const nested = '{"x":"12345678901234567,"}';
const result = safeJsonParse(nested);
Expand Down
Loading