Skip to content

Fix: Add minimum horizontal padding to prevent content cutoff at narrow viewport widths #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPHoughton merged 2 commits into from
Oct 30, 2025
Merged

Fix: Add minimum horizontal padding to prevent content cutoff at narrow viewport widths #1073

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a11d79
Initial plan
Copilot Oct 23, 2025
49f92c4
Add horizontal padding to prevent content from touching viewport edges
Copilot Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export default function App() {

const renderPlayer = (playerKey) => (
<div
className="h-screen relative overflow-auto"
className="h-screen relative overflow-auto px-4 sm:px-6 md:px-8"

Copilot AI Oct 30, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding horizontal padding to the root player container may conflict with existing absolute positioning patterns used in child components. The Game component at line 38 uses absolute top-12 left-0 right-0 bottom-0 m-2, and GenericIntroExitStep at line 55 uses absolute top-12 bottom-0 left-0 right-0. These absolute positioned children with left-0 and right-0 will extend beyond the parent's padding, potentially causing layout inconsistencies. Consider reviewing how these absolute positioned children interact with the new padding.

Suggested change
className="h-screen relative overflow-auto px-4 sm:px-6 md:px-8"
className="h-screen relative overflow-auto"

Copilot uses AI. Check for mistakes.
key={playerKey}
data-player-id={playerKey}
id={playerKey}
Expand Down
Loading