Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Gerrit patch-ref fetch to the MassMessage clone step in the 1.39-bundle Dockerfile:
Why
The 1.39 bundle pins MassMessage at
d6a86291bb975c3dc7778f370006f1145cc834bd, which lacks theMassMessageJobBeforeMessageSenthook (Gerrit change 1198560). This replicates the intent of upstream Canasta PR CanastaWiki#536 ("Checks out MassMessage REL1_39 onto patched version"), which Taqasta's 1.39 bundle did not yet include. Taqasta already cloned from Gerrit (the other half of upstream CanastaWiki#536), so only the patch-ref fetch was missing. The fetch+checkout can be dropped once Gerrit change 1198560 lands in the REL1_39 branch.Validation (no full image build)
git clone --single-branch -b REL1_39→checkout d6a8629...→git fetch ... refs/changes/60/1198560/1→git checkout FETCH_HEADcf374f74):includes/Job/MassMessageJob.php:323containsMassMessageJobBeforeMessageSent✓d6a8629...is an ancestor of the fetched patch commithadolint -c hadolint.yaml Dockerfile: exit 0 (remaining findings are pre-existing, unrelated lines)Ticket
https://wikiteq.atlassian.net/browse/WIK-2267