Skip to content

[WIK-2267] Switch 1.39 bundle to patched MassMessage (Canasta #536 equivalent) - #415

Open
tosfos wants to merge 2 commits into
REL1_39from
WIK-2267
Open

tosfos wants to merge 2 commits into
REL1_39from
WIK-2267

Conversation

@tosfos

@tosfos tosfos commented Aug 21, 2026

Copy link
Copy Markdown

What

Adds a Gerrit patch-ref fetch to the MassMessage clone step in the 1.39-bundle Dockerfile:

&& git fetch https://gerrit.wikimedia.org/r/mediawiki/extensions/MassMessage refs/changes/60/1198560/1 \
&& git checkout FETCH_HEAD \

Why

The 1.39 bundle pins MassMessage at d6a86291bb975c3dc7778f370006f1145cc834bd, which lacks the MassMessageJobBeforeMessageSent hook (Gerrit change 1198560). This replicates the intent of upstream Canasta PR CanastaWiki#536 ("Checks out MassMessage REL1_39 onto patched version"), which Taqasta's 1.39 bundle did not yet include. Taqasta already cloned from Gerrit (the other half of upstream CanastaWiki#536), so only the patch-ref fetch was missing. The fetch+checkout can be dropped once Gerrit change 1198560 lands in the REL1_39 branch.

Validation (no full image build)

  • Replicated the Dockerfile steps in a temp dir: git clone --single-branch -b REL1_39checkout d6a8629...git fetch ... refs/changes/60/1198560/1git checkout FETCH_HEAD
  • Base tree: hook absent; after checkout of FETCH_HEAD (cf374f74): includes/Job/MassMessageJob.php:323 contains MassMessageJobBeforeMessageSent
  • Verified pinned base d6a8629... is an ancestor of the fetched patch commit
  • hadolint -c hadolint.yaml Dockerfile: exit 0 (remaining findings are pre-existing, unrelated lines)

Ticket

https://wikiteq.atlassian.net/browse/WIK-2267

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f240c84f-8516-496b-b541-74cf897365fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant