Conversation
The --limit option was passed as a raw string into getReportData()'s ?int parameter, causing an uncaught TypeError on non-numeric input (and silent truncation on decimals). Validate it as a non-negative integer and fail with a clear message instead. The pipe-argument guard regex (/\|[^?]+/) rejected valid SMW syntax: value disjunctions ([[A::x||y]]) and printout modifiers (|+filter=...). Match only actual key=value printer parameters instead, so injection attempts like |format=json are still blocked. Bug: SLOP-134 SLOP-135 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SLOP-134, fixes SLOP-135
Summary
--limitwas passed as a raw string intogetReportData()'s?intparameter. Non-numeric input (--limit abc, empty) caused an uncaughtTypeError; decimals (10.5) were silently truncated with a deprecation notice. Now validated as a non-negative integer (/^\d+$/) with a clear fatal error, then cast to int. (This supersedes thefix-maintenance-limit-typebranch approach, which silently cast invalid input to 0 → empty report.)/\|[^?]+/rejected valid SMW query syntax — value disjunctions like[[Status::Active||Pending]]and printout modifiers like|+filter=/|+order=descending. Replaced with a pattern matching only actualkey=valueprinter parameters, so injection attempts (|format=json,|limit=5, even with spaces) are still blocked.Test plan
provideValidQueriescases prove print requests,||disjunctions, and|+filter=modifiers pass the guards (with the service mocked; no SMW query execution)php -lpasses on both changed filesWork performed by AI / Cursor Agent under direction of Ike.
Made with Cursor