Skip to content

Replace str_contains() with strpos() for PHP 7.4 compatibility (SLOP-133) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tosfos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace str_contains() with strpos() for PHP 7.4 compatibility (SLOP-133) #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion maintenance/GenerateReport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ public function execute() {
}

// enforce that the query does not contain curly braces
if ( str_contains( $query, '{' ) ) {
// (str_contains() is PHP 8+; this extension still supports 1.39/PHP 7.4)
if ( strpos( $query, '{' ) !== false ) {
$this->fatalError(
'Query cannot contain curly braces, i.e. use "[[Category:Test]] [[Property:Test]]", ' .
'not "{{#ask: [[Category:Test]] ... }}"'
Expand Down
Loading