Skip to content

Add revert risk model check to autoreview#87

Open
Nirmeet-kamble wants to merge 9 commits intoWikimedia-Suomi:mainfrom
Nirmeet-kamble:main
Open

Add revert risk model check to autoreview#87
Nirmeet-kamble wants to merge 9 commits intoWikimedia-Suomi:mainfrom
Nirmeet-kamble:main

Conversation

@Nirmeet-kamble
Copy link
Copy Markdown
Contributor

Address : #7

Integrates revert risk model to block auto-approval of edits with a high revert probability. Includes threshold configuration

Added unit tests.

@Nirmeet-kamble
Copy link
Copy Markdown
Contributor Author

@zache-fi Accidentally closed the PR earlier , raising it again.

Copy link
Copy Markdown
Contributor

@zache-fi zache-fi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff check and python manage.py test fails. Also the there is new migrations which arent include (ie. python manage.py makemigration result migration is missing from commit.

Also the opening web page fails so result is unable to test, but i was generally happy that there were code for configuration UI.

Comment thread app/templates/reviews/index.html Outdated
</body>
</section>
</div>
{% endverbatim %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws an error "TemplateSyntaxError : Exception Value: Invalid block tag on line 432: 'endverbatim'. Did you forget to register or load this tag?" . As it is outside of body and duplicated this is error in merge?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python manage.py test result is FAILED (errors=7)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Fixed!

@Nirmeet-kamble
Copy link
Copy Markdown
Contributor Author

@zache-fi Can you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants