Sort the options in --help alphabetically - #1043
Closed
VXNCXNX wants to merge 2 commits into
Closed
Conversation
When difftastic is given a single file, the error message did not say which file was inspected or why it was rejected. Name the file and state that it contains no conflict markers. Closes Wilfred#764 Written with AI assistance (Claude Code); I have read the change and am accountable for it.
The options were listed in declaration order, which is essentially arbitrary. Ask clap to sort them alphabetically instead. Closes Wilfred#830 Written with AI assistance (Claude Code); I have read the change and am accountable for it.
Contributor
Author
|
Closing in favour of #1044, which is the same change branched cleanly off master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1041, as you asked.
What's broken
difft --helplists options in declaration order, so related flags are scattered and there is no way to scan for one by name.The fix
next_display_order(None)tells clap to sort them alphabetically. One line, no behaviour change beyond the help output.Verification
cargo buildanddifft --helpshow the options sorted.cargo testpasses.