Add check if libgcc is available and link winpthreads against it instead of fakelib - #7
Closed
Blackhex wants to merge 1 commit into
Closed
Add check if libgcc is available and link winpthreads against it instead of fakelib#7Blackhex wants to merge 1 commit into
libgcc is available and link winpthreads against it instead of fakelib#7Blackhex wants to merge 1 commit into
Conversation
Blackhex
marked this pull request as draft
March 19, 2025 15:45
Blackhex
force-pushed
the
fix-stage2-fakelib
branch
3 times, most recently
from
March 19, 2025 15:55
c6e9c39 to
ba6b770
Compare
Blackhex
commented
Mar 19, 2025
Member
Author
There was a problem hiding this comment.
This file is updated automatically by automake.
Member
Author
There was a problem hiding this comment.
This file is updated automatically by autoconf.
Blackhex
changed the title
libgcc is available and link winpthreads against it instead of fakeliblibgcc is available and link winpthreads against it instead of fakelib
…instead of `fakelib`
Blackhex
force-pushed
the
fix-stage2-fakelib
branch
from
March 20, 2025 13:41
ba6b770 to
abc2a28
Compare
Blackhex
changed the title
libgcc is available and link winpthreads against it instead of fakeliblibgcc is available and link winpthreads against it instead of fakelib
Blackhex
marked this pull request as ready for review
March 22, 2025 21:00
Member
Author
|
This PR solves the same issue as #8 in different way. After discussions with MinGW community the other one seems like the preferred approach. So, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winpthreadsis linking against fake runtime library for stage 1 builds. During stage 2 whenlibgccis already available, this i not needed.This PR fixes Windows-on-ARM-Experiments/mingw-woarm64-build#208 and Windows-on-ARM-Experiments/mingw-woarm64-build#205.
Validated by https://github.com/Windows-on-ARM-Experiments/mingw-woarm64-build/actions/runs/13951078487