Open
Conversation
EwanGilligan
approved these changes
Sep 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 95.26% 94.64% -0.63%
==========================================
Files 43 39 -4
Lines 3488 3157 -331
==========================================
- Hits 3323 2988 -335
- Misses 165 169 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So after some hiatus, I am back. This pull request imports the group that Ruth gracefully provided, and adds some machinery in benchmark to test them as well! We will most likely want to change a bit which sets are benchmarked, but this is most of what we want.