Skip to content

Add serialization support for simple types#19

Open
oovm wants to merge 9 commits intoWolframResearch:masterfrom
oovm:serde
Open

Add serialization support for simple types#19
oovm wants to merge 9 commits intoWolframResearch:masterfrom
oovm:serde

Conversation

@oovm
Copy link
Copy Markdown
Contributor

@oovm oovm commented Mar 2, 2023

@oovm
Copy link
Copy Markdown
Contributor Author

oovm commented Mar 4, 2023

@ConnorGray Can you take a look at this feature?

Some of my libs which depends serde need to export api to wolfram by this feature.

@ConnorGray
Copy link
Copy Markdown
Collaborator

@oovm I appreciate you taking the time to prepare a PR with an important feature such as this, thank you for this contribution!

I do have some hesitation about the details of this design, but I also don't want this PR to get stuck and reduce your ability to use wolfram-expr. I propose that we put this new functionality behind a unstable-serde Cargo flag for the time being, and include a doc comment with an explicit warning that the serde functionality is semver exempt for the time being. I'll note the specifics of those changes in some review comments.

@ConnorGray
Copy link
Copy Markdown
Collaborator

@oovm Thank you again for submitting this contribution. I hope my suggestion that we put this behind a non-default unstable Cargo flag is a reasonable compromise for the time being, which will let us both start experimenting with this functionality before committing to a final design or behavior.

Please let me know if you have any questions or concerns about the proposed path forward, or with any of my specific review comments.

@oovm
Copy link
Copy Markdown
Contributor Author

oovm commented Mar 6, 2023

@ConnorGray New error handler can be found in src/error.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants