Editor: Prevent saving while a new taxonomy term is being created#78659
Open
Mamaduka wants to merge 3 commits into
Open
Editor: Prevent saving while a new taxonomy term is being created#78659Mamaduka wants to merge 3 commits into
Mamaduka wants to merge 3 commits into
Conversation
Mamaduka
added
[Type] Bug
|
Size Change: +160 B (0%) Total Size: 8.13 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in eb51bfe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26440561640
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #78558.
In
FlatTermSelectorandHierarchicalTermSelector, wrap thesaveEntityRecordcall that creates a new term withlockPostSaving/lockPostAutosaving, releasing in.finally()once the request(s) settle.I've also updated
FlatTermSelectorto use the new recommendedStackcomponent.Why?
Both components update the post's term IDs only after the
POST /wp/v2/<taxonomy>request resolves. If the user clicked Publish/Save during that window, the post was saved with the pre-creation term IDs. The new term existed in the database but wasn't associated with the post until a second save. The race was reliably reproducible on slower sites where the create request takes a few seconds.Testing Instructions
Testing Instructions for Keyboard
Same.
Use of AI Tools
Assisted by Claude. Mostly for review.