Hide paragraph Drop cap control when a state is selected#78672
Draft
talldan wants to merge 1 commit into
Draft
Conversation
talldan
added
[Type] Enhancement
|
Size Change: +16 B (0%) Total Size: 8.13 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Author
|
I should probably also hide 'Fit text' in this PR, it also doesn't currently work, and is typography related. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #78670, so that should be merged first. Also lets check perf results before merging this. If it shows issues I can look at further optimizations.
What?
Hides the paragraph block's drop cap control when a responsive state (Mobile / Tablet) is selected.
Why?
Currently changing drop cap for a given viewport isn't supported, so this avoid confusion for users.
The drop cap implementation will need some improvements for it to be supported.
How?
Hides the control by checking the
hasSelectedStyleState, which was implemented in #78670.Testing Instructions
Screenshots or screencast
Use of AI Tools
OpenCode / Codex