Validate additional CSS on mount#78682
Open
juanfra wants to merge 8 commits into
Open
Conversation
juanfra
added
[Type] Enhancement
Mamaduka
reviewed
May 26, 2026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -7 B (0%) Total Size: 8.18 MB 📦 View Changed
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 26, 2026
Mamaduka
reviewed
May 26, 2026
Member
|
@juanfra, you'll need to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
If you have invalid CSS saved in the Additional CSS field (either site-wide or per-block) and navigate away and come back, the error notice wouldn't appear until you actually interact with the field (typed or tabbed out of it).
This fix modifies the checks to show the CSS validation error notice immediately when the additional CSS panel mounts, without requiring any interaction.
Why?
If you had some invalid CSS saved you wouldn't have any indication that things were wrong until you interacted with the field.
How?
useState( null )always started with no error. We're replacing that with a lazy initializer. Two smaller refactors came along with this, so that we can re-use the checks for the different actions.Testing Instructions
Screenshots or screencast
additional-css-validate-1.mp4
additional-css-validate-2.mp4