-
Notifications
You must be signed in to change notification settings - Fork 153
Bump the wordpress-packages group across 1 directory with 4 updates and fix line-js errors #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cbbd057
Add build step before JS linting in workflow
mukeshpanchal27 d47ddc9
Update dependancies
mukeshpanchal27 f5cd566
Update config
mukeshpanchal27 cdd5d88
Fix lint errors
mukeshpanchal27 3d99ad9
Remove build step
mukeshpanchal27 b789168
Merge branch 'trunk' of https://github.com/WordPress/performance into…
westonruter e916eb8
ESLint: extend the @wordpress/scripts shared config
westonruter 59808e3
Build tools: Require Node.js >= 20.19
westonruter 2c8ae00
ESLint: split Node tooling and browser-code overrides
westonruter c20857b
ESLint: drop the dead `**/*.min.css` ignore
westonruter 0a05d8e
JS Lint workflow: match eslint.config.* instead of .eslint*
westonruter a287578
Drop unused catch bindings in favor of the optional catch binding
westonruter 847ef23
ESLint: include tools/ in the Node tooling override
westonruter d89bc02
Build tools: Pin .nvmrc to 20.19 to match engines.node
westonruter b5d7a37
ESLint: include root dotfile JS configs in the Node tooling override
westonruter 1aaafc7
ESLint: extract the Node tooling file list into a shared variable
westonruter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| #!/usr/bin/env node | ||
|
|
||
| /* eslint-disable no-console */ | ||
|
|
||
| /** | ||
| * External dependencies | ||
| */ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /** | ||
| * ESLint flat config. | ||
| * | ||
| * Extends the shared configuration shipped with `@wordpress/scripts` (which is | ||
| * based on the WordPress coding standards) and layers the project-specific | ||
| * tweaks on top. | ||
| */ | ||
|
|
||
| /** | ||
| * External dependencies | ||
| */ | ||
| const globals = require( 'globals' ); | ||
| // @ts-ignore -- No declaration file for this module. | ||
| const wpScriptsConfig = require( '@wordpress/scripts/config/eslint.config.cjs' ); | ||
|
|
||
| module.exports = [ | ||
| ...wpScriptsConfig, | ||
| { | ||
| // Ignore patterns in addition to those provided by @wordpress/scripts. | ||
| ignores: [ 'dist/', '**/*.min.js' ], | ||
| }, | ||
| { | ||
| // Browser globals for client-side scripts (everything but the Node tooling below). | ||
| files: [ '**/*.js' ], | ||
| ignores: [ 'bin/**', '*.config.js' ], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.browser, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| // Node-based build tooling and CLI scripts (CommonJS). | ||
| files: [ 'bin/**/*.js', '*.config.js' ], | ||
| languageOptions: { | ||
|
westonruter marked this conversation as resolved.
|
||
| sourceType: 'commonjs', | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
|
westonruter marked this conversation as resolved.
|
||
| rules: { | ||
| 'no-console': 'off', | ||
| }, | ||
| }, | ||
|
westonruter marked this conversation as resolved.
|
||
| { | ||
| files: [ '**/*.js' ], | ||
| rules: { | ||
| 'jsdoc/valid-types': 'off', | ||
| 'import/no-unresolved': [ | ||
| 'error', | ||
| { | ||
| // `@octokit/rest` is an ESM-only package referenced solely from | ||
| // JSDoc `@typedef` imports in `bin/plugin`, which the import | ||
| // resolver cannot follow. | ||
| ignore: [ '@octokit/rest' ], | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
|
westonruter marked this conversation as resolved.
|
||
| ]; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.