Skip to content

Add REST provider management and server-owned TOTP enrollment #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chubes4 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add REST provider management and server-owned TOTP enrollment #935

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
382c71e
feat: add REST provider management
chubes4 Jul 22, 2026
1940948
fix: reject nonexistent REST users
chubes4 Jul 23, 2026
eb7e9aa
fix: bound REST TOTP confirmation codes
chubes4 Jul 24, 2026
a3f28d0
fix: distinguish unchanged enrollment meta
chubes4 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions TESTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,18 @@ Tests the abstract `Two_Factor_Provider` base class:
- `is_supported_for_user` (globally registered vs. not)
- Default implementations of `get_alternative_provider_label`, `pre_process_authentication`, `uninstall_user_meta_keys`, `uninstall_options`

### Provider Settings REST API — `tests/class-two-factor-rest-api.php`

**Class:** `Tests_Two_Factor_REST_API` · **Groups:** `core`, `rest-api`
Tests the authenticated provider settings endpoints:

- Self and administrator permission boundaries
- Provider status and TOTP secret redaction
- Email and recovery-code management
- Configured, enabled, and primary-provider invariants
- Recent revalidation responses and targets
- Session invalidation for self-service and administrator changes

### TOTP Provider — `tests/providers/class-two-factor-totp.php`

**Class:** `Tests_Two_Factor_Totp` · **Groups:** `providers`, `totp`
Expand All @@ -95,6 +107,7 @@ Extends `WP_Test_REST_TestCase`. Tests the TOTP REST endpoints:

- Setting a TOTP key with a valid/invalid/missing auth code
- Updating an existing TOTP key
- Server-owned enrollment creation, confirmation, replacement, expiry, and replay prevention
- Deleting own secret
- Admin deleting another user's secret
- Non-admin cannot delete another user's secret
Expand Down
Loading
Loading