Skip to content

FEDX-2722: Update the ignore field to ignore everything, not just specific checks #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btr-rmconsole-4 merged 2 commits into from
Mar 6, 2025
Merged

FEDX-2722: Update the ignore field to ignore everything, not just specific checks #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cef1b6
Support the ignore field for packages that are ignored, contain execu…
matthewnitschke-wk Mar 6, 2025
b7d4e69
minor rework
matthewnitschke-wk Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/src/dependency_validator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@ Future<void> run() async {
.difference(packagesUsedInPublicFiles)
.difference(packagesUsedOutsidePublicDirs)
// Remove this package, since we know they're using our executable
..remove(dependencyValidatorPackageName);
..remove(dependencyValidatorPackageName)
..removeAll(ignoredPackages);

final packageConfig = await findPackageConfig(Directory.current);
if (packageConfig == null) {
Expand Down Expand Up @@ -338,9 +339,6 @@ Future<void> run() async {
);
}

// Ignore known unused packages
unusedDependencies.removeAll(ignoredPackages);

if (unusedDependencies.isNotEmpty) {
log(
Level.WARNING,
Expand Down