FEDX-4095: Resolve dart3 formatting issues#47
Merged
btr-rmconsole-5[bot] merged 2 commits intomasterfrom Oct 17, 2025
Merged
Conversation
matthewnitschke-wk
changed the title
bender-wk
changed the title
alanknight-wk
approved these changes
Oct 17, 2025
btr-rmconsole-4
bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEDX-4095
There's a nuanced issue with the checks workflow in the format job
Since many of workiva repos rely on the package
workiva_analysis_optionsin theiranalysis_options.yamlfile, and content within that file can effect formatting results, if you dont run pub-get to resolve that dependency before running formatting, you will get fmt changes.See Workiva/dependency_validator#160 for an example of this issue
This PR simply runs pub get before running
dart formatto resolve these issues