Removed Virtual Entry from image and provision in tng-iac level#112
Open
arajnor99 wants to merge 1 commit into
Open
Removed Virtual Entry from image and provision in tng-iac level#112arajnor99 wants to merge 1 commit into
arajnor99 wants to merge 1 commit into
Conversation
Removed Virtual Entry from image and provision in tng-iac level for TNG Gateway as env variable on gateway deployment .
arajnor99
requested review from
ascheibal,
litlfred and
tence
as code owners
tence
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed hardcoded virtual country entries from the TNG and KDS image repositories.
Provisioning is now handled at the tng-iac level:
For TNG Gateway → via environment variables in the ConfigMap (referenced in the Deployment).
For KDS → via entries in values.yaml.
Notes
DEV team ( @ascheibal / @kotharikaushal ) needs to remove the virtual countries list entries from the application.yaml files in both the tng-key-distribution and smart-trust-network-gateway repositories, as I don’t have privileges to create a new branch in the tng-key-distribution repo.
Please see Jira ticket for more details: WHOGDHCN-1039
.
Subject Pull Request for TNG Gateway ( [smart-trust-network-gateway])
Kindly review and approve this pull request for the TNG changes