Open
Conversation
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
force-pushed
the
pr/dix-use-xorg-list-saveset-list-_2025-12-11_17-59-14
branch
from
695c460 to
4adf438
Compare
Contributor
|
@metux Are these arrays heavily used for random access/addition/removal? If so, we're significantly impacting performance by moving to linked lists. |
Contributor
Author
I really doubt that. In general, usage of saveset's should be pretty rare. |
metux
force-pushed
the
pr/dix-use-xorg-list-saveset-list-_2025-12-11_17-59-14
branch
3 times, most recently
from
08eac20 to
4b3ad73
Compare
metux
force-pushed
the
pr/dix-use-xorg-list-saveset-list-_2025-12-11_17-59-14
branch
from
4b3ad73 to
c960c61
Compare
Simplify saveSet handling by just using trivial `struct xorg_list` instead of complicated dynamically resized array. Common operations like insert or remove are much simpler using lists instead of arrays. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify saveSet handling by just using trivial
struct xorg_listinsteadof complicated dynamically resized array. Common operations like insert or
remove are much simpler using lists instead of arrays.
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net