mi: mioverlay: turn overlay functions into dummies#1787
Open
mi: mioverlay: turn overlay functions into dummies#1787
Conversation
Contributor
Author
|
@ONykyf @stefan11111 @b-aaz @josephcrowell @cepelinas9000 can anybody please test this one against various Nvidia driver versions (also the older ones) ? |
metux
force-pushed
the
draft/mi-overlay-dummy
branch
from
c5c5239 to
fb0076e
Compare
Contributor
Personally, I don't have any Nvidia cards any more. I'm all the way AMD. |
metux
force-pushed
the
draft/mi-overlay-dummy
branch
from
fb0076e to
da04330
Compare
Those shouldn't be called anymore for decades now, but proprietary nvidia drivers still referencing them. Hopefully they don't call them anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Since no drivers are compiled against this anymore, and the mioverlay.c functions only dummies just to satisfy proprietary Nvidia driver's symbol dependencies, this header isn't needed anymore. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Since these are just dummies needed for compat with proprietary Nvidia driver, they're better off in the compat directory. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
draft/mi-overlay-dummy
branch
from
22234f5 to
85eab33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those shouldn't be called anymore for decades now, but proprietary nvidia drivers still referencing them. Hopefully they don't call them anymore.
This is an alternative to #1786 if that one doesn't work.
Still need to test whether these functions are actually called by the Nvidia driver and how it copes with them now being just dummies.