Skip to content

Turn amendments to supported yes for attackathon#6857

Merged
kennyzlei merged 1 commit intoripple/attackathon-april-2026from
kennyzlei/supported-yes-attackathon
Apr 10, 2026
Merged

Turn amendments to supported yes for attackathon#6857
kennyzlei merged 1 commit intoripple/attackathon-april-2026from
kennyzlei/supported-yes-attackathon

Conversation

@kennyzlei
Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

XRPL_FEATURE(BatchV1_1, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FEATURE(ConfidentialTransfer, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FEATURE(MPTokensV2, Supported::yes, VoteBehavior::DefaultNo)
XRPL_FIX (Security3_1_3, Supported::yes, VoteBehavior::DefaultNo)
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about this one, but assuming it would be safe to have these included

Copy link
Copy Markdown
Contributor

@xrplf-ai-reviewer xrplf-ai-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V14

@kennyzlei kennyzlei added the Attackathon Used to label PRs created for Attackathon branch label Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ripple/attackathon-april-2026@2570c7d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             ripple/attackathon-april-2026   #6857   +/-   ##
===============================================================
  Coverage                                 ?   82.1%           
===============================================================
  Files                                    ?    1036           
  Lines                                    ?   78676           
  Branches                                 ?    7659           
===============================================================
  Hits                                     ?   64596           
  Misses                                   ?   14080           
  Partials                                 ?       0           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennyzlei kennyzlei merged commit ac4f142 into ripple/attackathon-april-2026 Apr 10, 2026
32 checks passed
@kennyzlei kennyzlei deleted the kennyzlei/supported-yes-attackathon branch April 10, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Attackathon Used to label PRs created for Attackathon branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants