feat: Add --definitions flag and artifact#6858
Open
pdp2121 wants to merge 4 commits intoXRPLF:developfrom
Open
feat: Add --definitions flag and artifact#6858pdp2121 wants to merge 4 commits intoXRPLF:developfrom
--definitions flag and artifact#6858pdp2121 wants to merge 4 commits intoXRPLF:developfrom
Conversation
--definitions flag and artifact--definitions flag and artifact
mvadari
reviewed
Apr 10, 2026
| return RPC::invalid_field_error(jss::hash); | ||
| } | ||
|
|
||
| static detail::ServerDefinitions const defs{}; |
Collaborator
There was a problem hiding this comment.
You should refactor this to use the helper function you just added, so there's only one static variable
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6858 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.0%
=========================================
Files 1010 1010
Lines 75982 75988 +6
Branches 7633 7634 +1
=========================================
+ Hits 61982 61983 +1
- Misses 14000 14005 +5
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds a
--definitionsCLI flag to xrpld that outputs server definitions as JSON and exits, without starting the server.CI is updated to export and upload
server_definitions.jsonas a build artifact on every run.Context of Change
This is particularly valuable for SDK maintainers (e.g. xrpl.js, xrpl-py) who need up-to-date definitions early in a feature's development cycle, before a Docker image is available or a branch is merged to develop.
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Before / After
Before: Generating definitions.json for downstream SDKs required either running a live
server_definitionsRPC call against a running node, or maintaining a custom regex-based script to extract definitions from source.After: SDK maintainers can build and use
--definitionsflag to generate the json file, or simply download theserver-definitionsartifact directly from any CI run.Test Plan
CI passes and artifact generated.