chore: Enable all clang-tidy checks

[mathbunnyru]

High Level Overview of Change

WIP just to see how many problems are there

Results:

Unique errors per check:
22366 cppcoreguidelines-pro-bounds-avoid-unchecked-container-access
19552 cppcoreguidelines-avoid-magic-numbers
19337 modernize-use-trailing-return-type
15047 readability-identifier-length
1588 misc-non-private-member-variables-in-classes
1563 readability-uppercase-literal-suffix
 969 readability-named-parameter
 887 performance-unnecessary-value-param
 824 misc-override-with-different-visibility
 719 bugprone-throwing-static-initialization
 713 cppcoreguidelines-avoid-const-or-ref-data-members
 703 misc-unused-parameters
 664 misc-use-anonymous-namespace
 634 misc-use-internal-linkage
 617 cppcoreguidelines-special-member-functions
 577 readability-static-accessed-through-instance
 556 readability-function-cognitive-complexity
 555 cppcoreguidelines-pro-bounds-pointer-arithmetic
 506 bugprone-narrowing-conversions
 459 cppcoreguidelines-pro-bounds-array-to-pointer-decay
 458 cppcoreguidelines-non-private-member-variables-in-classes
 377 readability-qualified-auto
 336 modernize-avoid-c-style-cast
 320 bugprone-easily-swappable-parameters
 295 cppcoreguidelines-avoid-non-const-global-variables
 290 readability-avoid-const-params-in-decls
 229 cppcoreguidelines-pro-bounds-constant-array-index
 216 performance-enum-size
 212 cppcoreguidelines-avoid-c-arrays
 173 modernize-use-integer-sign-comparison
 173 performance-unnecessary-copy-initialization
 166 cppcoreguidelines-pro-type-union-access
 148 cppcoreguidelines-pro-type-reinterpret-cast
 147 readability-isolate-declaration
 146 performance-avoid-endl
 143 readability-inconsistent-declaration-parameter-name
 139 modernize-return-braced-init-list
 124 misc-no-recursion
 104 cppcoreguidelines-macro-usage
  98 misc-multiple-inheritance
  94 readability-redundant-access-specifiers
  84 cppcoreguidelines-noexcept-move-operations
  81 cppcoreguidelines-missing-std-forward
  60 readability-container-data-pointer
  56 cppcoreguidelines-avoid-do-while
  44 bugprone-exception-escape
  38 cppcoreguidelines-owning-memory
  29 bugprone-implicit-widening-of-multiplication-result
  29 cppcoreguidelines-interfaces-global-init
   4 cppcoreguidelines-c-copy-assignment-signature

Context of Change

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.6%. Comparing base (ab3ff66) to head (1256b7c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #7803   +/-   ##
=======================================
  Coverage     82.6%   82.6%           
=======================================
  Files         1036    1036           
  Lines        79943   79943           
  Branches      8941    8936    -5     
=======================================
+ Hits         66035   66049   +14     
+ Misses       13899   13885   -14     
  Partials         9       9           

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.