Trying to fix muting when dragging sound tracks and pausing#148
Open
sthy14 wants to merge 3 commits into
Open
Conversation
This change also seems resolved the pausing problem. Seems that sometimes pausing would cause WindowName to be empty.
sthy14
changed the title
A pause is a pause
Xeroday
force-pushed
the
master
branch
4 times, most recently
from
ca6662c to
0bcf31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to drag a sound track ezblocker will mute spotify, as the WindowName will change to Drag. I added one condition so that it will hopefully not mute spotify on Dragging.
I've removed the following code automatically playing the ad, which solves the problem of pausing.
else if (playingAd) { AudioUtils.SendPlayPause(hook.Handle); } // If here, means we were in an ad state, but Spotify was paused and ad is no longer playingFor my normal routine this works fine, as I really want to pause when I leave my seat.