fix: retry to get cloud device list until successfully fetching device online state when the network resumes#1555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In #1519 , after the router restarts, xiaomi_home refreshes the cloud device list when it detects the network to be reconnected to the internet. However, the http post session fails because of "DNS server returned answer with no data" error. User reloads xiaomi_home manually and the http post session succeed. It seems that DNS request is easily to fail soon after the router restarts.
If xiaomi_home does not get the latest device online state from the cloud device list, all the cloud devices will be shown as offline devices whose properties and events would not be subscribed by xiaomi_home. From the cloud service perspective, the brief disconnection of IoT devices caused by a router reboot is not sufficient to classify the devices as offline. The cloud service continues to regard them as online and therefore does not push a “state online” message to xiaomi_home. So the devices are alway unavaible after the router reboot.
Fixed