Skip to content

fix: drop non-UTF-8 cloud mips message instead of crashing mqtt loop #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Heartcoolman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: drop non-UTF-8 cloud mips message instead of crashing mqtt loop #1750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion custom_components/xiaomi_home/miot/miot_mips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,16 @@ def _on_mips_message(self, topic: str, payload: bytes) -> None:
if not bc_list:
return
# The message from the cloud is not packed.
payload_str: str = payload.decode('utf-8')
try:
payload_str: str = payload.decode('utf-8')
except UnicodeDecodeError as err:
# Some cloud pushes carry a payload that is not valid UTF-8.
# Drop the message instead of raising, otherwise the exception
# aborts paho's read loop and subsequent messages may be lost.
self.log_error(
f'on message, drop non-utf-8 payload, {err}, {topic}, '
f'{payload.hex()}')
return
# self.log_debug(f"on broadcast, {topic}, {payload}")
for item in bc_list or []:
if item.handler is None:
Expand Down