Fix/wic: Fix TypeError in bootimg-partition by adding sector_size argument#73
Fix/wic: Fix TypeError in bootimg-partition by adding sector_size argument#73albayenes wants to merge 1 commit intoXilinx:rel-v2025.2from
Conversation
|
I also got the issue and was really surprised. Overriding wic in a base layer is quite invasive. But this one from meta-xilinx-core is taking the precedence. We can lower the xilinx priority but could you consider moving your custom wic to a sub layer ? |
|
@Louson We needed to add several features to wic in order to use it with our EDF workflows. Upstream has agreed to these changes, but getting them into upstream takes time. We needed these changes for our release, which is based on scarthgap. As a stop-gap we added this kludge in order to release. Work is progressing to get these things upstream. Once these changes are integrated upstream, we are looking forward to removing this override as well! |
|
That's understable ! But could you consider to active the xilinx-wic only in your images ? Having that in layer.conf is a little bit hard.
Le 4 février 2026 20:23:16 GMT+01:00, Trevor Woerner ***@***.***> a écrit :
…twoerner left a comment (Xilinx/meta-xilinx#73)
@Louson We needed to add several features to wic in order to use it with our EDF workflows. Upstream has agreed to these changes, but getting them into upstream takes time. We needed these changes for our release, which is based on scarthgap. As a stop-gap we added this kludge in order to release. Work is progressing to get these things upstream. Once these changes are integrated upstream, we are looking forward to removing this override as well!
--
Reply to this email directly or view it on GitHub:
#73 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
Hello, First, thanks @albayenes for submitting the fix! @twoerner would there be there any updates on this topic? would you know when this PR will be merged? Thanks! |
|
@albayenes could you please add your SoB line? |
|
Hello, maybe check others |
albayenes
force-pushed
the
fix/wic-bootimg-sector-size-api
branch
from
2ddff72 to
f916f6a
Compare
Wic core now passes sector_size as a keyword argument. This update ensures the meta-xilinx-core local plugin matches the expected API signature and prevents a TypeError during image generation. Signed-off-by: Enes Albay <albayenes@gmail.com>
albayenes
force-pushed
the
fix/wic-bootimg-sector-size-api
branch
from
f916f6a to
871d875
Compare
Fixed. |
|
@albayenes can you send the patches to mailing lists, We usually don't use Github PR for patches. See https://github.com/Xilinx/meta-xilinx/blob/master/MAINTAINERS.md |
6 participants
Description
This PR resolves a build failure during the do_image_wic task. The error is caused by a signature mismatch in the bootimg-partition source plugin.
The Issue
When using recent versions of the Yocto Project (Poky), the Wic engine's partition.py calls the plugin's do_prepare_partition method with an additional sector_size keyword argument. Because the meta-xilinx-core local copy of this plugin does not include this parameter in its method definition, the build fails with:
The Fix
Updated the do_prepare_partition method signature in scripts/lib/wic/plugins/source/bootimg-partition.py to accept the sector_size argument. This ensures compatibility with the upstream Wic engine API.
Testing Performed
Environment: Yocto Project (Poky) with meta-xilinx.
Build Target: petalinux-image-minimal (or your specific machine, e.g., xczu2eg).
Result: do_image_wic completes successfully, and the resulting .wic image is generated without errors.