fix(p2p/enode): fix endpoint determination for IPv6 #29801

[gzliudan]

Proposed changes

Ref: ethereum#29801

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69aab505-ce4b-4a1a-bfa5-f1def446a514

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR updates p2p/enode.Node endpoint selection to correctly determine and prefer the “most global” announced address across IPv4/IPv6 (not always preferring IPv4), and switches endpoint handling to netip for clearer address semantics.

Changes:

• Add enr.IPv4Addr/enr.IPv6Addr entries backed by netip.Addr for ENR "ip" / "ip6" keys.
• Cache the selected endpoint (ip, udp, tcp) inside enode.Node at construction time, using a locality-based preference between IPv4 and IPv6.
• Update URL/CLI endpoint formatting and add a table-driven test for endpoint selection behavior.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
p2p/enr/entries.go	Adds netip-based ENR IP entry types for "ip" and "ip6".
p2p/enode/node.go	Introduces cached endpoint fields and locality-based IPv4/IPv6 endpoint selection.
p2p/enode/nodedb.go	Updates DB node decoding to reconstruct nodes via the new constructor logic.
p2p/enode/urlv4.go	Switches URL formatting “missing IP” check to use cached netip validity.
p2p/enode/idscheme.go	Ensures SignNull returns a node with endpoint cache initialized.
p2p/enode/node_test.go	Adds endpoint-selection tests for mixed IPv4/IPv6 records.
cmd/devp2p/discv4cmd.go	Updates endpoint formatting to use IPAddr().IsValid() instead of Incomplete().

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.