Switch to scikit build core#127
Open
hokiedsp wants to merge 7 commits into
Open
Conversation
d4f58fc to
2ff5c52
Compare
Contributor
Author
|
OK, I figured out Here is the This creates the Once this is done, you can go about doing things CMake way to rebuild: Finally, you can uninstall the editable install: |
0aa5126 to
b5e6a2c
Compare
b5e6a2c to
c3cfc3e
Compare
ef0654d to
2f30bfd
Compare
2f30bfd to
a35f462
Compare
for more information, see https://pre-commit.ci
a35f462 to
ed3e077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was playing with CMake build process, I found that
scikit-buildfolks have their own python build backend.I tried to switch to it and I think I'm successful at it, I think. It must be done with
project.tomlso I switched the meta data over to it from the cfg file.One thing I haven't achieved is to support the dynamic version data with their method. I poked around their website for a bit and came away not sure what to do (as I forgot 99% of how CMake works...) Here is the info, as limited as it may be:
https://scikit-build-core.readthedocs.io/en/latest/faqs.html#dynamic-setup-py-options
For now, I've relegated to
setuptoolsby using the alternate build-backendscikit_build_core.setuptools.build_meta, which if I understand correctly takes the info from the good ol'setup.py.Donno if you are interested in updating this part of the project, but if you are, you can use this as a spring board.