Fix upgrade - #219
Fix upgrade#219CodeShakingSheep wants to merge 25 commits into
Conversation
Don't replace config file
|
!testme |
|
🌻 |
|
📚 |
Keep composer.json
|
!testme |
|
Alrighty! |
|
🐛 |
Keep composer.lock
|
!testme |
|
May the CI gods be with you! |
|
📚 🐛 |
--keep option doesn't support wildcards
|
!testme |
|
📖 |
|
Meow 🐈 |
Upgrades fail because of an already existing table |
|
!testme |
|
🚀 |
|
!testme |
|
📖 🪱 |
|
Hey @ericgaspar , Anyways, since Roundcube 1.5 email addresses of recipients are collected automatically, see https://kolabian.wordpress.com/2020/09/26/collected-recipients-and-trusted-senders/ and roundcube/roundcubemail#6904 . So, what the problematic plugin did became a Roundcube core feature. Therefore, I'd suggest to just remove the plugin. What do you think? Also, I saw that you updated PHP version to 8.5 in your latest PR. That might be a bit too soon as full PHP 8.4 support will come with RC 1.7, see https://roundcube.net/news/2025/07/14/roundcube-1.7-beta-released . So, I think in 1.6 we should stick to PHP 8.3 for now. |
|
!testme |
|
📖 🪱 |
|
!testme |
|
Remember: a failing test is just a misunderstood spicy feature! |
|
@ericgaspar I updated this branch and added some fixes. This should fix #259 . Can you merge it? |
|
!testme |
|
Fingers crossed! |
|
Just upgraded roundcube from version 1.16.14~ynh1 with this branch. Upgrade went through smoothly, no issues with plugins afterwards. |
|
!testme |
|
Remember: a failing test is just a misunderstood spicy feature! |
|
|
||
| # Download, check integrity, uncompress and patch the source from app.src | ||
| ynh_setup_source --dest_dir="$install_dir/tmp_aaa" | ||
| ynh_setup_source --dest_dir="$install_dir" --full_replace=1 --keep="composer.json composer.lock config/ logs/ plugins/ vendor/" |
There was a problem hiding this comment.
I disagree with this approach, what was done was done because that's what official doc suggests.
I know there are rough edges around the fact that /bin/env php returns wrong PHP CLI, but this is not the way to fix it.
|
!testme |
|
Remember: a failing test is just a misunderstood spicy feature! |
4 participants
Don't replace config file
Problem
After the last update the contextmenu extension wasn't working anymore as the
config/config.inc.phpfile had been overridden from the template file leading to the installed extensions not being present anymore after this line: https://github.com/YunoHost-Apps/roundcube_ynh/blob/master/conf/config.inc.php#L140Solution
Keep
config/config.inc.phpand don't override it with the template.PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)