port resource: take secondary ports into account#2289
Open
hbrunn wants to merge 2 commits intoYunoHost:devfrom
Open
port resource: take secondary ports into account#2289hbrunn wants to merge 2 commits intoYunoHost:devfrom
hbrunn wants to merge 2 commits intoYunoHost:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
port conflicts when an app uses multiple ports and isn't running at install time of second instance
Solution
adjust the regex searching for ports in use to also search for secondary ports
PR Status
...
How to test
install an app that uses multiple ports, ie libererp_ynh. stop the app, install another instance of the app and observe that without the patch, the chat port of the second instance will be 8072, while it should be 8073