Strengthen historical nlsat regression tests#9857
Open
peter941221 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tightens two historical
nlsatregressions that were still print-only.Closes #9859.
In
tst_16, the test already exercises the oldlws2380shape, but it only dumped the projected clause. On currentmaster, both projection paths still keep thex7-linked root constraints, so this change turns that observation into an assertion and updates the stale comment to describe the current invariant.In
tst_22, the test already computes whether the projected lemma is falsified at the stored counterexample. It previously printed the result and kept going. This change addsENSURE(!all_false)so the test fails if that historical unsoundness shape comes back.Testing:
cmake --build . --target test-z3 -j1./test-z3 /seq nlsat