ci: allow the non-local variant of the semicolon-in-expressions lint in tests

[gustavovalverde]

Motivation

The Nightly unused dependencies job in Advisory Checks fails to compile tower-batch-control and zebra-rpc:

error: trailing semicolon in macro used in expression position
   --> tower-batch-control/tests/worker.rs:39:15
   = note: `-D semicolon-in-expressions-from-non-local-macros` implied by `-D warnings`

Same compiler change as #11131. rustc split semicolon_in_expressions_from_macros by macro locality, and macros from external crates moved into the new non-local variant. #11131 covered uint::construct_uint! in zebra-chain. These are the remaining two sites: tokio-test's assert_ready_err! and insta's assert_json_snapshot!, both used in expression position.

They only surface in jobs that compile test targets under -D warnings, which is why the docs build went green without them.

Solution

Same three-attribute pattern as #11131, applied at each affected file.

unknown_lints is required: only nightly knows the new lint name, so naming it directly makes stable and the MSRV toolchains emit unknown_lints, which is warn-by-default and therefore fatal under clippy's -D warnings.

Tests

Found by compiling the whole workspace rather than grepping, since cargo stops scheduling work after the first failing unit and masks later ones. It took three passes to reach a clean build; the zebra-rpc site was hidden behind the tower-batch-control failure.

• cargo +nightly check --workspace --all-targets --all-features under RUSTFLAGS=-D warnings: clean. This is the first pass over the workspace with no instances of this lint remaining.
• cargo +stable clippy -p tower-batch-control -p zebra-rpc --all-features --all-targets -- -D warnings: clean, confirming no unknown_lints regression.
• cargo test -p tower-batch-control --test worker: 2 passed.
• cargo test -p zebra-rpc --lib --all-features -- test_rpc_response_data: passed.
• cargo fmt --all -- --check: clean.

Specifications & References

• Tracking Issue for denying trailing semicolons in expression macro bodies rust-lang/rust#79813
• Same lint, first two sites: ci: allow the non-local variant of the semicolon-in-expressions lint in u256 #11131, fix(ci): silence semicolon-in-expressions-from-macros in u256 #10986

Follow-up Work

book.yml and advisory.yml pair an unpinned nightly toolchain with -D warnings, so any rustc lint addition or split turns these jobs red without a code change. Worth deciding separately whether to pin.

AI Disclosure

• AI tools were used: Claude Code for the workspace lint sweep, the fixes, and this description.

PR Checklist

• The PR title follows conventional commits format: type(scope): description
• The PR follows the contribution guidelines.
• This change was discussed in an issue or with the team beforehand.
• The solution is tested.
• The documentation and changelogs are up to date. CI-only fix with no user-visible change, matching ci: allow the non-local variant of the semicolon-in-expressions lint in u256 #11131.

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-07-29 18:07 UTC · Rule: batched · triggered by rule move to any queue if GitHub Rulesets are satisfied
• ✅ Checks passed · on draft merge queue: checking main (f44ce94) and #11141 together #11144
• ✅ Merged — 2026-07-29 18:37 UTC · at acde0c8244e72aba7c29dce2ed2b08cb8d36cba3 · merge

This pull request spent 30 minutes 1 second in the queue, including 29 minutes 14 seconds running CI.

Required conditions to merge

• #review-threads-unresolved = 0 [🛡 GitHub repository ruleset rule PR Requirements]
  • ci: allow the non-local variant of the semicolon-in-expressions lint in tests #11141
• github-review-approved [🛡 GitHub branch protection]
  • ci: allow the non-local variant of the semicolon-in-expressions lint in tests #11141
• github-review-approved [🛡 GitHub repository ruleset rule PR Requirements]
  • ci: allow the non-local variant of the semicolon-in-expressions lint in tests #11141
• any of [🛡 GitHub repository ruleset rule PR Requirements]:
  • check-success = @github-actions/lint
  • check-neutral = @github-actions/lint
  • check-skipped = @github-actions/lint
• any of [🛡 GitHub repository ruleset rule PR Requirements]:
  • check-success = test-crates
  • check-neutral = test-crates
  • check-skipped = test-crates
• any of [🛡 GitHub repository ruleset rule PR Requirements]:
  • check-success = unit-tests
  • check-neutral = unit-tests
  • check-skipped = unit-tests